Skip to content

Conversation

@aabhas-sao
Copy link
Contributor

@aabhas-sao aabhas-sao commented Oct 18, 2021

Description

@isabelcosta I have fixed the syntax error in the deploy.yml file. As I could not find any workflows in GitHub actions, I couldn't verify it but the syntax error is rectified so it should work.

Fixes #312

Type of Change:

Delete irrelevant options.

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

Copy link
Contributor

@brittanyjoiner15 brittanyjoiner15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing @aabhas-sao 🙌🏾 Hope this fixes the issue 🤞🏾

@isabelcosta
Copy link
Member

I will merge and cross my fingers :)

@isabelcosta isabelcosta merged commit 59680b2 into anitab-org:develop Oct 18, 2021
@isabelcosta
Copy link
Member

@aabhas-sao it worked 🥳 🙌🏾 Thank you very much for fixing this 🙌🏾
Just for reference, this fixed an error introduced in #305
cc @ftonato just so you know about this fix

ftonato pushed a commit to ftonato/anitab-org.github.io that referenced this pull request Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GitHub Actions is not deploying the project to GitHub Pages

3 participants